improve read_object speed when passing idx #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
📢 Thoughts on this report? Let us know! |
|
We should still allow directly reading with slice objects. How would the user do that? |
|
Ok nevermind, slices are used when setting |
|
Thanks for the idea, Luigi! I changed it so that if |
gipert
reviewed
Nov 9, 2023
|
looks very good to me. I'm going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #29 for details of issue and fix. "Fixes" this issue by sacrificing a small amount memory for additional speed. This can improve
read_objectspeeds when using theidxparameter by more than x50 depending on how many events are selected from a file.There is now a x2 speed penalty if the user passes in
idxthat corresponds to all events compared to just reading everything without anyidx. In the future,read_objectcould check if the user did this. For now, however, it is up the user to check.